Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add creation time to evaluations table #6050

Merged
merged 3 commits into from
Aug 22, 2019
Merged

Conversation

backspace
Copy link
Contributor

This addresses #4920 and relies on the API changes in #5881.

I added the modifyTime attribute to the model but not the table, if that’s undesirable, it’s easily removed.

@backspace backspace marked this pull request as ready for review August 21, 2019 14:41
@backspace
Copy link
Contributor Author

I was awaiting feedback on the original issue, but since that’s seemingly not forthcoming, I’m submitting this for review anyway.

@backspace backspace requested review from DingoEatingFuzz and a team August 21, 2019 14:42
@backspace backspace changed the title Add creation time to evaluations table UI: Add creation time to evaluations table Aug 21, 2019
Copy link
Contributor

@DingoEatingFuzz DingoEatingFuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and straightforward.

At first I was surprised there were no acceptance test failures, but it looks like the job evaluations acceptance tests don't assert table cell values :/

@backspace backspace merged commit 2364fb2 into master Aug 22, 2019
@backspace backspace deleted the f-ui/evaluation-creation branch August 22, 2019 13:11
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants